mike-tr-adamson commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269381440
##########
src/java/org/apache/cassandra/db/streaming/CassandraStreamReceiver.java:
##########
@@ -242,6 +245,12 @@ public void finished()
}
else
{
+ // Validate SSTable-attached indexes that should have streamed
in an already complete state. When we
+ // don't stream the entire SSTable, validation is unnecessary,
as the indexes have just been written
+ // via the SSTable flush observer, and an error there would
have aborted the streaming transaction.
+ if (receivedEntireSSTable)
+ cfs.indexManager.validateSSTableAttachedIndexes(readers,
true);
Review Comment:
It's still not entirely clear here that the validation can throw here and
abort the stream. It would be nice to be clear on this and what the
consequences are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
