mike-tr-adamson commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269369491
##########
src/java/org/apache/cassandra/index/sai/disk/StorageAttachedIndexWriter.java:
##########
@@ -209,13 +204,11 @@ public void abort(Throwable accumulator)
*/
public void abort(Throwable accumulator, boolean fromIndex)
{
+ if (aborted) return;
+
// Mark the write operation aborted, so we can short-circuit any
further operations on the component writers.
aborted = true;
- // Make any indexes involved in this transaction non-queryable, as
they will likely not match the backing table.
- if (fromIndex)
- indexes.forEach(StorageAttachedIndex::makeIndexNonQueryable);
-
Review Comment:
I'm in favour of this change. I never felt that it should be down to the
index to say whether or not it is queryable. Particularly at this point in the
writer. Short of validating the index here we have no idea whether it is valid
or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
