maedhroz commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269841911
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -249,9 +249,9 @@ public void handleNotification(INotification notification,
Object sender)
{
SSTableAddedNotification notice = (SSTableAddedNotification)
notification;
- // Avoid validation for index files just written following
Memtable flush.
- IndexValidation validate = notice.memtable().isPresent() ?
IndexValidation.NONE : IndexValidation.CHECKSUM;
- onSSTableChanged(Collections.emptySet(), notice.added, indexes,
validate);
+ // Avoid validation for index files just written following
Memtable flush. Otherwise, the new SSTables have
+ // come either from import, streaming, or a standalone tool, where
they have also already been validated.
+ onSSTableChanged(Collections.emptySet(), notice.added, indexes,
IndexValidation.NONE);
Review Comment:
SIM handles the notification, but it will no longer trigger builds for SAI,
given SAI will now return true from `Index#isSSTableAttached()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
