mike-tr-adamson commented on code in PR #2492:
URL: https://github.com/apache/cassandra/pull/2492#discussion_r1269365079
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -249,9 +249,9 @@ public void handleNotification(INotification notification,
Object sender)
{
SSTableAddedNotification notice = (SSTableAddedNotification)
notification;
- // Avoid validation for index files just written following
Memtable flush.
- IndexValidation validate = notice.memtable().isPresent() ?
IndexValidation.NONE : IndexValidation.CHECKSUM;
- onSSTableChanged(Collections.emptySet(), notice.added, indexes,
validate);
+ // Avoid validation for index files just written following
Memtable flush. Otherwise, the new SSTables have
+ // come either from import, streaming, or a standalone tool, where
they have also already been validated.
+ onSSTableChanged(Collections.emptySet(), notice.added, indexes,
IndexValidation.NONE);
Review Comment:
This is close to the change that I added in my original patch for
CASSANDRA-18653. At this point, we should already know that the indexes are
built and valid. If they aren't then we aren't in a position to build them
anyway. I'm wondering whether we always need to do this here or whether we only
need to do it if a memtable is present. The SIM handles the notification as
well and will trigger a build if the memtable is not present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
