dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309146831
##########
accord-core/src/main/java/accord/impl/InMemoryCommandStore.java:
##########
@@ -408,63 +464,39 @@ void update(Ranges add)
}
}
- static class CFKEntry extends TxnId
+ enum Loader implements CommandLoader<Command>
Review Comment:
CFK is supposed to be immutable, but the old `CFKEntry` used the global
backing commands map and would return updated values, making CFK mutable!
Switched away from mutable loader to immutable loader to better match the
expected behavior and what C* does...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
