dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309150411
##########
accord-core/src/main/java/accord/impl/SimpleProgressLog.java:
##########
@@ -277,7 +277,7 @@ void run(SafeCommandStore safeStore, SafeCommand
safeCommand)
updateMax(success.asProgressToken());
}
- });
+ }).begin(node.agent());
Review Comment:
the leak detector found this case. `CommandStore` returns a `AsyncChain`
and not `AsyncResult`! In Cassandra we use `AsyncChains.Head` so require
`begin` to start, but in the in-memory stories we returned a `AsyncResult`
which would make code work under tests but not in C*...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
