dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309175076


##########
accord-core/src/test/java/accord/burn/BurnTest.java:
##########
@@ -357,6 +420,7 @@ public static void main(String[] args)
     @Test
     public void testOne()
     {
+//        run(726880888609333L, 1000); // taking a long time...  gave up after 
15 minutes!

Review Comment:
   will revert, this is just a seed that hit a while true loop in recovery. 
Spoke to Benedict and seems that his branch may fix this



##########
accord-core/src/test/java/accord/burn/BurnTest.java:
##########
@@ -311,6 +373,7 @@ static void burn(RandomSource random, TopologyFactory 
topologyFactory, List<Id>
 
         logger.info("Received {} acks, {} nacks, {} lost, {} truncated ({} 
total) to {} operations", acks.get(), nacks.get(), lost.get(), truncated.get(), 
acks.get() + nacks.get() + lost.get() + truncated.get(), operations);
         logger.info("Message counts: {}", messageStatsMap.entrySet());
+        logger.info("Took {} and in logical time of {}", 
Duration.ofNanos(System.nanoTime() - startNanos), 
Duration.ofMillis(queue.nowInMillis() - startLogicalMillis));

Review Comment:
   this was mostly for me... I wanted to get a better grasp of how much 
"logical" time has passed as there is a lot of delayed logic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to