dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309155743
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -498,7 +508,7 @@ public Topologies withUnsyncedEpochs(Unseekables<?> select,
long minEpoch, long
return withSufficientEpochs(select, minEpoch, maxEpoch, epochState ->
epochState.syncComplete);
}
- public Topologies withOpenEpochs(Unseekables<?> select, Timestamp min,
Timestamp max)
+ public Topologies withOpenEpochs(Unseekables<?> select, EpochSupplier min,
EpochSupplier max)
Review Comment:
this was updated for `ListStore` as it works with historic epochs; so rather
than define a full `Timestamp`, using `EpochSupplier` allowed `() -> epoch` as
well in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
