dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309151457
##########
accord-core/src/main/java/accord/messages/TxnRequest.java:
##########
@@ -234,7 +234,7 @@ public static <I, O> O computeScope(Node.Id node,
Topologies topologies, I keys,
O scope = null;
for (int i = startIndex, mi = topologies.size() ; i < mi ; ++i)
{
- Topology topology = topologies.get(i);
+ Topology topology = topologies.get(i).global();
Review Comment:
this was a bug found with remove prefix. The subset topologies would leak
the `global` values and not the subset values, which caused the scope logic to
work as it works off `global`, so once this was fixed I had to be explicit and
ask for the `global` values...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
