dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309152741
##########
accord-core/src/main/java/accord/messages/WaitUntilApplied.java:
##########
@@ -170,6 +170,7 @@ private ReadNack apply(SafeCommandStore safeStore,
SafeCommand safeCommand)
}
else
{
+ // TODO (debug): this will cause us to send a Nack back,
so why are we listening?
Review Comment:
will remove, but in debugger I wasn't sure why we do this... `NotCommitted`
causes the process to return a `Nack` which causes the waiting to halt! In my
usage I keep retrying the wait over and over again when a `NotCommitted` or a
`Timeout` is observed...
##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -147,11 +179,6 @@ public boolean isSubset()
return supersetIndexes.length < shards.length;
}
- public Topology withEpoch(long epoch)
Review Comment:
moved to `TopologyUtils` under `src/test` as the semantics are not clear
what to do here... *should* this also update the `global` reference? Since
this was only used by tests and only for the `global` state anyways felt was
easier to punt figuring out the semantic and just make it a test method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
