dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309184802
##########
accord-core/src/test/java/accord/impl/basic/DelayedCommandStores.java:
##########
@@ -52,6 +59,28 @@ public static CommandStores.Factory factory(PendingQueue
pending)
new DelayedCommandStores(time, agent, store, random,
shardDistributor, progressLogFactory, new
SimulatedDelayedExecutorService(pending, agent, random));
}
+ @Override
+ protected boolean shouldBootstrap(Node node, Topology previous, Topology
updated, Range range)
+ {
+ if (!super.shouldBootstrap(node, previous, updated, range))
+ return false;
+ if (!(range.start() instanceof PrefixedIntHashKey)) return true;
Review Comment:
I think this logic could be rewritten to
`previous.ranges.containsAll(Ranges.of(range))` which should actually match the
C* logic... can switch but wasn't sure if there would be edge cases where we
don't want that as the default behavior...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
