dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309173411
##########
accord-core/src/test/java/accord/burn/BurnTest.java:
##########
@@ -243,6 +283,12 @@ static void burn(RandomSource random, TopologyFactory
topologyFactory, List<Id>
if (i == requests.length - 1)
onSubmitted.get().run();
}
+ if (packet.message instanceof Reply.FailureReply)
Review Comment:
hit a NPE in the `List*` code which hit this case... so assuming the `List*`
is bug free we should never hit this, but rather than hitting a class cast felt
that the original exception was best so adding directly to the failures was
better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
