dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309176680
##########
accord-core/src/test/java/accord/coordinate/tracking/TrackerReconcilerTest.java:
##########
@@ -67,7 +67,14 @@ void test(int count, BiFunction<RandomSource, Topologies, ?
extends TrackerRecon
static <ST extends ShardTracker, T extends AbstractTracker<ST>, E extends
Enum<E>>
void test(long seed, BiFunction<RandomSource, Topologies, ? extends
TrackerReconciler<ST, T, E>> constructor)
{
- for (TrackerReconciler<?, ?, ?> test :
TrackerReconciler.generate(seed, constructor))
- test.test();
+ try
+ {
+ for (TrackerReconciler<?, ?, ?> test :
TrackerReconciler.generate(seed, constructor))
+ test.test();
+ }
+ catch (Throwable t)
+ {
+ throw new AssertionError("Failure for seed " + seed, t);
Review Comment:
unrelated to the core work, but was found when doing the topology
refactors... the current test relies on logging which means that CI is unlikely
to give us the seed we failed with, making theses property tests not
reproducible... by throwing with the seed we should be able to repo issues
assuming the property tests are deterministic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
