dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1309212177
##########
accord-core/src/test/java/accord/burn/BurnTest.java:
##########
@@ -354,6 +418,7 @@ public static void main(String[] args)
}
}
+ @Timeout(value = 3, unit = TimeUnit.MINUTES)
Review Comment:
this is so the test times out rather than the build... when while true loops
are found the build times out due to no progress... felt it was best to have
the test timeout...
One issue with this is that the seed will be lost... we don't depend on
`org.awaitility` like C* does, so could also add that test dependency and
update the `run(seed)` method to do this timeout and log the seed on failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
