JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379217458
##########
src/test/integration/org/apache/cassandra/testing/AbstractCassandraTestContext.java:
##########
@@ -67,10 +69,24 @@ public void close()
{
cluster.close();
}
- catch (ShutdownException shutdownException)
+ // ShutdownException may be thrown from a different classloader,
and therefore the standard
+ // `catch (ShutdownException)` won't always work - compare the
canonical names in stead.
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
