JeetKunDoug commented on code in PR #74: URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379234157
########## src/main/java/org/apache/cassandra/sidecar/config/yaml/DriverConfigurationImpl.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.config.yaml; + +import java.net.InetSocketAddress; +import java.util.ArrayList; +import java.util.List; + +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.cassandra.sidecar.config.DriverConfiguration; + +/** + * The driver configuration to use when connecting to Cassandra + */ +public class DriverConfigurationImpl implements DriverConfiguration +{ + private final List<InetSocketAddress> contactPoints = new ArrayList<>(); + private String localDc; + private int numConnections; + + @JsonProperty("contact_points") + public List<InetSocketAddress> contactPoints() + { + return contactPoints; + } + + @JsonProperty("num_connections") + public int numConnections() + { + return numConnections; Review Comment: It's done at usage - we take any number < the min additional connections (a constant, currently 2) and use 2 instead. Anything > the total number of instances in the cluster ends up being treated as "all the hosts" - both of these conditions log at `warn` level but allow the system to continue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
