JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379218868
##########
src/main/java/org/apache/cassandra/sidecar/cluster/CassandraAdapterDelegate.java:
##########
@@ -332,6 +361,11 @@ protected void markAsDownAndMaybeNotify()
@Nullable
private <T> T fromAdapter(Function<ICassandraAdapter, T> getter)
{
+ if (this.adapter == null)
Review Comment:
There was a reason I had to do this before, but I think it was added before
I actually started running scheduled health checks in the Integration tests -
without it, at the time, tests couldn't succeed if they tried to do things like
creating a keyspace as they use the same session that the Sidecar does, and it
wouldn't exist.
I've removed it and rerun the integration tests and it seems happy now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
