JeetKunDoug commented on code in PR #74:
URL: https://github.com/apache/cassandra-sidecar/pull/74#discussion_r1379242771
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java:
##########
@@ -42,16 +49,18 @@ public class CassandraAdapter implements ICassandraAdapter
private static final Logger LOGGER =
LoggerFactory.getLogger(CassandraAdapter.class);
protected final DnsResolver dnsResolver;
protected final JmxClient jmxClient;
- private final CQLSessionProvider session;
+ private final CQLSessionProvider cqlSessionProvider;
private final String sidecarVersion;
+ private final InetSocketAddress broadcastRpcAddress;
- public CassandraAdapter(DnsResolver dnsResolver, JmxClient jmxClient,
CQLSessionProvider session,
- String sidecarVersion)
+ public CassandraAdapter(DnsResolver dnsResolver, JmxClient jmxClient,
CQLSessionProvider cqlSessionProvider,
+ String sidecarVersion, InetSocketAddress
broadcastRpcAddress)
Review Comment:
Yeah - there were some struggles with this.. at one point it _was_ the
broadcastRpcAddress being used, which was why I used that particular name. I'll
change them all to `localNativeTransportAddress` which should make it clearer
what we're asking for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
