ekaterinadimitrova2 commented on PR #3173: URL: https://github.com/apache/cassandra/pull/3173#issuecomment-1994469579
`generate.sh -a is unnecessary iiuc. It's noop. We're changing nothing there correct?` I tested yesterday that it is not noop. The deletion lines in the script trigger the removal of the correct repeated jobs from the default files which makes sense to me. I pulled your branch, removed the `do not merge` commit and ran `./generate.sh -a` ``start` jobs get automatically deleted when you delete a job if a regexp matches.` That is unclear and brittle. Why some jobs are removed by regex and some are deleted by us? What is this regex meant for originally? We should have either the regex deal with all the `start_` jobs or rely on our manual deletion. Otherwise it becomes prone to bugs and messy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
