bereng commented on code in PR #3173: URL: https://github.com/apache/cassandra/pull/3173#discussion_r1523336403
########## .circleci/generate.sh: ########## @@ -391,22 +396,20 @@ build_dev_min_jobs() delete_job "$1" "j17_utests_fqltool" delete_job "$1" "j17_utests_long" delete_job "$1" "j17_utests_stress" - delete_job "$1" "j17_utests_trie" - delete_job "$1" "j17_utests_trie" + delete_job "$1" "j11_utests_latest" + delete_job "$1" "j17_utests_latest" delete_job "$1" "j17_utests_system_keyspace_directory" - delete_job "$1" "start_utests_trie" delete_job "$1" "start_utests_system_keyspace_directory" delete_job "$1" "start_utests_stress" delete_job "$1" "start_utests_long" delete_job "$1" "start_utests_fqltool" delete_job "$1" "start_utests_compression" delete_job "$1" "start_utests_cdc" - delete_job "$1" "start_utests_trie" Review Comment: I'm not sure I am following. This is what it has always [been](https://github.com/apache/cassandra/pull/3173/commits/9351754c928505696bd39d7ba587b0f870f11cf4#diff-9405c8896ec20e5e91399a71f450251c8da83d336df2d3a00c66d6c914ca05b4R275), known behavior and we even recently reviewed that regexp match in another ticket. If we want to change that to make it specific it's going to be _very_ verbose to remove each `start_` job individually. Food for another ticket imo, specially since it's going to hit _all_ branches. Not convinced about the value at this point imo either. Let's merge this one to fix the problem in this ticket imo and discuss heavy refactorings elsewhere, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
