bereng commented on code in PR #3173: URL: https://github.com/apache/cassandra/pull/3173#discussion_r1524325207
########## .circleci/generate.sh: ########## @@ -391,22 +396,20 @@ build_dev_min_jobs() delete_job "$1" "j17_utests_fqltool" delete_job "$1" "j17_utests_long" delete_job "$1" "j17_utests_stress" - delete_job "$1" "j17_utests_trie" - delete_job "$1" "j17_utests_trie" + delete_job "$1" "j11_utests_latest" + delete_job "$1" "j17_utests_latest" delete_job "$1" "j17_utests_system_keyspace_directory" - delete_job "$1" "start_utests_trie" delete_job "$1" "start_utests_system_keyspace_directory" delete_job "$1" "start_utests_stress" delete_job "$1" "start_utests_long" delete_job "$1" "start_utests_fqltool" delete_job "$1" "start_utests_compression" delete_job "$1" "start_utests_cdc" - delete_job "$1" "start_utests_trie" Review Comment: Let's go bit by bit: - That a regexp is used is known and there was a bug fixed in CASSANDRA-19410. In this [comment](https://issues.apache.org/jira/browse/CASSANDRA-19410?focusedCommentId=17819957&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17819957) the problem about some job names not having a common prefix is identified. - The `dev` workflow is just the std workflow renamed (CASSANDRA-19414). So the problem with jobs not having a common prefix is in the std workflows and known. - There isn't a 'dev' circle workflow introduced in 5.0 and trunk. It's just the std one but trimmed and renamed. it's the same yaml. - Are you suggesting changing all the job names to follow the convention but only in 5.0 and trunk? Given the `dev` workflow _is_ the std's workflow yaml then it does also imply multi-branch, big refactor, little value to this ticket, etc imo rename. You don't want to rename the std workflow's jobs only in 5.0 and trunk. Iiuc I don't want to do a multi-branch renaming of jobs in this ticket. We can do that in the future one where we'll revisit the pre-commit workflow i.e. We can decide there if we like the regexp technique or not, rename any jobs to a convention, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
