ekaterinadimitrova2 commented on code in PR #3173: URL: https://github.com/apache/cassandra/pull/3173#discussion_r1523718803
########## .circleci/generate.sh: ########## @@ -391,22 +396,20 @@ build_dev_min_jobs() delete_job "$1" "j17_utests_fqltool" delete_job "$1" "j17_utests_long" delete_job "$1" "j17_utests_stress" - delete_job "$1" "j17_utests_trie" - delete_job "$1" "j17_utests_trie" + delete_job "$1" "j11_utests_latest" + delete_job "$1" "j17_utests_latest" delete_job "$1" "j17_utests_system_keyspace_directory" - delete_job "$1" "start_utests_trie" delete_job "$1" "start_utests_system_keyspace_directory" delete_job "$1" "start_utests_stress" delete_job "$1" "start_utests_long" delete_job "$1" "start_utests_fqltool" delete_job "$1" "start_utests_compression" delete_job "$1" "start_utests_cdc" - delete_job "$1" "start_utests_trie" Review Comment: If the problem was really with the regex - I agree we need to fix it in all branches in another ticket. The issue is actually with the naming in `java_11_dev_tests` and `java_17_dev_tests` and it exists only in 5.0 and trunk. There is start_utests_long but the actual job names are prefixed with j11_ and j17_. And we also created `start_jX_cqlsh-dtests-latest` to rule all the Python versions. The mentioned regex was created for the repeated jobs where the naming convention is followed, and everything is fine. I am not blocking anyone, but the issue is with the dev workflow, which was supposed to be fixed in this ticket, and it covers only 5.0 and trunk, where the dev workflow was committed. Probably you did not realize it is the naming and not the regex. We need to follow the naming conventions and to be consistent. This is something we also got as feedback from the community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
