bereng commented on code in PR #3173: URL: https://github.com/apache/cassandra/pull/3173#discussion_r1525930628
########## .circleci/generate.sh: ########## @@ -391,22 +396,20 @@ build_dev_min_jobs() delete_job "$1" "j17_utests_fqltool" delete_job "$1" "j17_utests_long" delete_job "$1" "j17_utests_stress" - delete_job "$1" "j17_utests_trie" - delete_job "$1" "j17_utests_trie" + delete_job "$1" "j11_utests_latest" + delete_job "$1" "j17_utests_latest" delete_job "$1" "j17_utests_system_keyspace_directory" - delete_job "$1" "start_utests_trie" delete_job "$1" "start_utests_system_keyspace_directory" delete_job "$1" "start_utests_stress" delete_job "$1" "start_utests_long" delete_job "$1" "start_utests_fqltool" delete_job "$1" "start_utests_compression" delete_job "$1" "start_utests_cdc" - delete_job "$1" "start_utests_trie" Review Comment: Icwym. You want to split that function into 2 for better readability. Why wouldn't you want to do that to all branches? The script is the same in that area in all branches so it would be cleaner forward merges when the script changes. So we can copy-paste this suggestion to CASSANDRA-19407 i.e. which I intend to tackle once 5.0 is done. Does it work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
