ekaterinadimitrova2 commented on code in PR #3173:
URL: https://github.com/apache/cassandra/pull/3173#discussion_r1525091299
##########
.circleci/generate.sh:
##########
@@ -391,22 +396,20 @@ build_dev_min_jobs()
delete_job "$1" "j17_utests_fqltool"
delete_job "$1" "j17_utests_long"
delete_job "$1" "j17_utests_stress"
- delete_job "$1" "j17_utests_trie"
- delete_job "$1" "j17_utests_trie"
+ delete_job "$1" "j11_utests_latest"
+ delete_job "$1" "j17_utests_latest"
delete_job "$1" "j17_utests_system_keyspace_directory"
- delete_job "$1" "start_utests_trie"
delete_job "$1" "start_utests_system_keyspace_directory"
delete_job "$1" "start_utests_stress"
delete_job "$1" "start_utests_long"
delete_job "$1" "start_utests_fqltool"
delete_job "$1" "start_utests_compression"
delete_job "$1" "start_utests_cdc"
- delete_job "$1" "start_utests_trie"
Review Comment:
`Are you suggesting changing all the job names to follow the convention but
only in 5.0 and trunk? `
Not at all :-)
But I should apologize to you, I was looking at config.yml workflow and I
thought we change the start buttons names only... I thought I am looking into
the config_template.yml.
Yes, that definitely will not work.
To make it clear what is going on here I suggest we modify the delete_job
something like this and call it a day until we have time for proper fix. Then
it will be at least clear what and why we do it when we need to get back to it
next time:
Here's a refactored version with two functions:
```
# Function to delete a specific YAML block.
delete_specific_yaml_block()
{
sed -Ei.bak "/^ - ${2}/,/^ [^[:space:]]+|^ [^[:space:]]+/{//!d;}"
"$1"
sed -Ei.bak "/^ - ${2}/d" "$1"
}
# Function to delete a job with the option to delete additional related
blocks.
delete_job()
{
file="$BASEDIR/$1"
# Delete the specific block.
delete_specific_yaml_block "$file" "${2}:"
# Delete the additional related block.
delete_specific_yaml_block "$file" "start_${2}:"
}
# Now, you have the flexibility to directly call delete_specific_yaml_block
if you want to delete only a specific block.
# Example usage to delete just one block:
# delete_specific_yaml_block "$BASEDIR/filename.yaml" "job_name:"
# And use delete_job to perform the full original behavior.
# Example usage to delete both related blocks:
# delete_job filename.yaml job_name
```
I haven't tested it, if you are fine with the idea, I can spin the patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
