On Wed, Aug 20, 2014 at 2:50 PM, Robert Edmonds <[email protected]> wrote:
> 'Feng Xiao' via Protocol Buffers wrote: > > Hi Robert, > > Can you help send a patch for this issue to > https://codereview.appspot.com/ > > (and add me as a reviewer)? We'll commit it to svn once it's reviewed. I > > also pinged [email protected] > > <https://code.google.com/u/110106420545796050291/> who provided a patch > for > > this issue some time ago. Not sure if he is still around. Are you both > > Debian/Red Hat maintainers? > > Hi, Feng Xiao: > > Yes, I am the protobuf package maintainer for the Debian project. > > Here is the patch that I applied against protobuf 2.5.0 for Debian: > > > http://anonscm.debian.org/cgit/collab-maint/protobuf.git/plain/debian/patches/fix-ftbfs-upstream-issue-488.patch > > It is based on Stanislav Ochotnicky's patch. Feel free to import it > into your code review system. > Can you help to do this? We'll probably need some changes to the patch but as we can't test it in the relevant platforms the code review is better to be initiated by someone who can make the change and test the change. It's very simple to create such a code review request. Just run a upload.py script in svn directory with the patch: https://codereview.appspot.com/use_uploadpy > > Note that this patch is probably not directly suitable as-is for > inclusion in the protobuf mainline. > > -- > Robert Edmonds > > -- > You received this message because you are subscribed to the Google Groups > "Protocol Buffers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/protobuf. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
