As no mail arrived here or qpid-dev, and none seems to have arrived at what
used to be the default location (infra-dev) either, I had a quick look and
it seems like they might have changed the process slightly and we will need
to ask for the mails to be enabled at all:
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and

I particularly like the mention of the new comment syncing between our
mailing list and the Pull Requests.

Regarding closing the pull requests, it seems like something along the
lines of "This closes #<request number> at GitHub" added to the end of the
svn commit message should do the trick:
https://help.github.com/articles/closing-issues-via-commit-messages

I havent had a chance to really look at the actual code change but when I
was quickly scrolling down the PR, in addition to the licence headers on
the new files that Rafi already mentioned (which I spotted due to the
Copyright notices we wouldnt typically have) I noticed Encoder.java having
its existing licence header corrupted a little by some wayward code.

Robbie
I just submitted it as a git PR:

https://github.com/apache/qpid-proton/pull/1



On Apr 30, 2014, at 10:47 AM, Robbie Gemmell <robbie.gemm...@gmail.com>
wrote:

> I think anyone can sign up for ReviewBoard themselves. It certainly didn't
> used to be linked to the ASF LDAP in the past, presumably for that reason.
>
> Its probably also worth noting you can initiate pull requests against the
> github mirrors. If it hasn't already been done for the proton mirror, we
> can have the emails that would generate be directed to this list (e.g.
>
http://mail-archives.apache.org/mod_mbox/qpid-dev/201401.mbox/%3c20140130180355.3cf9e916...@tyr.zones.apache.org%3E
).
> We obviously can't merge the pull request via github, but you can use
> the reviewing tools etc and the resultant patch can be downloaded or
> attached to a JIRA and then applied in the usual fashion (I believe there
> is a commit message syntax that can be used to trigger closing the pull
> request).
>
> Robbie
>
> On 30 April 2014 15:22, Rafael Schloming <r...@alum.mit.edu> wrote:
>
>> On Wed, Apr 30, 2014 at 8:35 AM, Clebert Suconic <csuco...@redhat.com
>>> wrote:
>>
>>> @Rafi: I see there is a patch review  process within Apache (based on
>> your
>>> other thread on Java8)
>>>
>>> Should we make this through the patch process at some point?
>>>
>>
>> I'm fine looking at it on your git branch, but if you'd like to play with
>> the review tool then feel free.  Just let me know if you need an account
>> and I will try to remember how to set one up (or who to bug to get you
>> one). ;-)
>>
>> --Rafael
>>

Reply via email to