Hi,

Review Board was never intended to work with Subversion repository paths
that point to a subdirectory. Repositories should always point to the root
of the repository, because RBTools and the New Review Request page are
going to try to generate paths that are relative to the root of the
repository. That's how those ended up with the extra "trunk" in the path a
couple of times.

It looks like you have a mix of changes on your server that either have the
right path or the wrong path. I don't know why it would have worked before
but not now, but we've fixed a large number of Subversion issues since
1.6.x, and rewrote the Subversion backend, so perhaps there's a behavioral
change somewhere. I'd have to know more about how those particular changes
were posted to really help diagnose that.

The right thing to do here is to switch the repository URL to not point to
a subdirectory. However, that will break existing review requests. So what
I'd recommend is archiving the current repository entry (and keeping the
path as-is), and then adding a new repository entry pointing to the root of
the server, and give it the same name. RBTools and the New Review Request
page will do the correct thing, and you won't have this sort of issue going
forward.

That won't fix existing review requests, though. For that, either the
database entries would need to be updated to point to the correct path, or
a patch to Review Board would need to be written that tries to remove that
duplicate information when normalizing the path, for misconfigured
repositories.

Christian

-- 
Christian Hammond - [email protected]
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Thu, May 28, 2015 at 6:41 AM, Papaswede <[email protected]> wrote:

> Oh, and I just noticed that a few of the existing reviews still do work,
> but about 90% of them do not. I was clicking through some at random and
> found that some do show up correctly. I'm not sure what's wrong with the
> ones that aren't showing up.
>
> On Wednesday, May 27, 2015 at 12:28:40 PM UTC-4, Papaswede wrote:
>
>> I upgraded ReviewBoard from 1.6.11 to 2.0.15. After doing this, I get
>> error messages when attempting to view the diffs of the existing reviews. I
>> get messages like:
>>
>> The file
>> '("'/svn/enrollment/!svn/bc/122232/trunk/4X/enrollment/trunk/trunk/4X/webapps/common/src/main/java/bf/web/common/form/AddEmployeeForm.java'
>> path not found", 160013)' could not be found in the repository
>>
>> Where that path definitely is not a valid svn path. It should
>> be 
>> /svn/enrollment/!svn/bc/122232/trunk/4X/webapps/common/src/main/java/bf/web/common/form/AddEmployeeForm.java.
>>
>> So, it's like there's stuff being automatically inserted into the svn
>> path for the file, but I have no idea why as it was working on version
>> 1.6.11.
>>
>> Any help would be greatly appreciated.
>>
>  --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to