Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@94 PS1, Line 94: <th>Outbound Queue Size</th> Can we mention the unit here (count, bytes)? http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@96 PS1, Line 96: {{#per_conn_metrics}} For large clusters I'm a bit worried that this could get too large and would make the page very hard to navigate. We could move it to the /backends page, which already has one row per cluster member. Alternatively we could use a DataTables table like we do for /varz and for the fragment instances of a query. This would make it searchable and add pagination. http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@232 PS1, Line 232: conn_outbound_queue_size unused? -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:46:09 +0000 Gerrit-HasComments: Yes
