Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9384/3/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/3/www/rpcz.tmpl@227 PS3, Line 227: "pageLength": 50 > If you add a mapping of keys to columns here, will you be able to feed the I couldn't pass the JSON in directly, since it didn't accept that format. So I converted it to an array format before adding it. But I moved the mapping of keys to columns at the initialization here, so we don't need to modify the function body as more metrics become available. -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2018 21:49:44 +0000 Gerrit-HasComments: Yes
