Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/9384/2/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9384/2/be/src/rpc/rpc-mgr.cc@203 PS2, Line 203: inbound_connections Why are we counting the inbound connections? I thought this change was about outbound connections, am I missing something? http://gerrit.cloudera.org:8080/#/c/9384/2/be/src/rpc/rpc-mgr.cc@208 PS2, Line 208: Value remote_ip_str(conn.remote_ip().c_str(), document->GetAllocator()); Should we add a check here that the remote IPs are actually unique? That could make it much easier to identify the issue if they ever end up not being unique. http://gerrit.cloudera.org:8080/#/c/9384/2/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/2/www/rpcz.tmpl@98 PS2, Line 98: {{#per_conn_metrics}} : <tr> : <td id="{{remote_ip}}_remote_ip">{{remote_ip}}</td> : <td id="{{remote_ip}}_outbound_queue_size">{{outbound_queue_size}}</td> : </tr> : {{/per_conn_metrics}} I think the <tbody> should be empty when using DataTables (see www/query_finstances.tmpl). My understanding is that DataTables will immediately clear the table and replace it with its own content anyways. This should probably be fixed in flags.tmpl. I might be wrong, in which case it should be fixed in query_finstances.tmpl and query_backends.tmpl. http://gerrit.cloudera.org:8080/#/c/9384/2/www/rpcz.tmpl@237 PS2, Line 237: function update_krpc_conn_metrics(json) { I think this needs to be change now to update the table through the DataTables API. The other pages that use the plugin just pass an Ajax URL to the DataTables ctor, but that seems unfeasible here since the rest of the page is updated by our code. You'll likely want to chain these three calls: https://datatables.net/reference/api/clear https://datatables.net/reference/api/rows.add https://datatables.net/reference/api/draw -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 18:26:11 +0000 Gerrit-HasComments: Yes
