Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9384 )

Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for 
Reactor threads
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9384/2/be/src/rpc/rpc-mgr.cc
File be/src/rpc/rpc-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/9384/2/be/src/rpc/rpc-mgr.cc@208
PS2, Line 208:     Value remote_ip_str(conn.remote_ip().c_str(), 
document->GetAllocator());
> In what case would it not be unique? I think we can rely on the fact that K
I was thinking about the case where that KRPC guarantee breaks but you're 
right, it's probably not worth the effort.


http://gerrit.cloudera.org:8080/#/c/9384/3/www/rpcz.tmpl
File www/rpcz.tmpl:

http://gerrit.cloudera.org:8080/#/c/9384/3/www/rpcz.tmpl@227
PS3, Line 227:         var key = keys[l];
If you add a mapping of keys to columns here, will you be able to feed the json 
into rows.add()?



--
To view, visit http://gerrit.cloudera.org:8080/9384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c
Gerrit-Change-Number: 9384
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 21:25:57 +0000
Gerrit-HasComments: Yes

Reply via email to