Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9384 )

Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for 
Reactor threads
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl
File www/rpcz.tmpl:

http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@94
PS1, Line 94:       <th>Outbound Queue Size (count)</th>
> Can we mention the unit here (count, bytes)?
Done


http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@96
PS1, Line 96:   </thead>
> For large clusters I'm a bit worried that this could get too large and woul
I couldn't figure out how to display this on the /backends page, since the code 
flow assumes anything in the RpcMgr will be displayed on the /rpcz page, 
however, I was able to get DataTables working, and set a default of 50 entries.


http://gerrit.cloudera.org:8080/#/c/9384/1/www/rpcz.tmpl@232
PS1, Line 232:
> unused?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c
Gerrit-Change-Number: 9384
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 17:57:41 +0000
Gerrit-HasComments: Yes

Reply via email to