Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 21: (5 comments) http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis-test.cc File be/src/service/query-profile-ai-analysis-test.cc: http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis-test.cc@141 PS20, Line 141: } : : TEST(QueryProfileAiAnalysisHelpersTest, MaxConcurrentSlots > Done Done http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc File be/src/service/query-profile-ai-analysis-test.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc@169 PS21, Line 169: constexpr int32_t kMaxConcurrentRuns = 3; : const auto scoped_max_concurrent_runs = ScopedFlagSetter<int32_t>::Make( : &FLAGS_query_profile_ai_analysis_max_concurrent_runs, kMaxConcurrentRuns); : while (TryAcquireAiAnalysisSlot()) { : } : for (int i = 0; i < kMaxConcurrentRuns; ++i) ReleaseAiAnalysisSlot(); This test can be simplified by calling ASSERT_TRUE(TryAcquireAiAnalysisSlot()) then calling ReleaseAiAnalysisSlot() twice with the second call wrapped in IMPALA_ASSERT_DEBUG_DEATH http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@79 PS20, Line 79: using namespace std; : : namespace impala { > Done Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@87 PS20, Line 87: const > Done Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@133 PS20, Line 133: } > Done Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 21 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 22:44:53 +0000 Gerrit-HasComments: Yes
