Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 21: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.h File be/src/service/query-profile-redaction.h: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.h@78 PS21, Line 78: std::string redacted_profile_text_; We probably don't need to store the redacted_profile_text_ anymore? Also no one is directly consuming the redacted_profile_text_? The caller also only consumes redacted_profile_json_. http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.cc@535 PS21, Line 535: static Status RedactSourceJson(const Value& source_json, int64_t profile_size_limit_bytes, We should probably revisit the redaction class. I think we should try to minimize data copies for redaction. Current logic does DOM -> String -> Redacted String -> Redacted DOM. Ideally we want to go from DOM -> Redacted DOM. We could address this in a later patch as it requires quite a lot of changes in Redaction module. -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 21 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 00:03:48 +0000 Gerrit-HasComments: Yes
