Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc File be/src/service/query-profile-ai-analysis-test.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc@145 PS21, Line 145: 4 > query_profile_ai_analysis_max_concurrent_runs by default is 3, maybe we cha Done http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc@169 PS21, Line 169: constexpr int32_t kMaxConcurrentRuns = 1; : const auto scoped_max_concurrent_runs = ScopedFlagSetter<int32_t>::Make( : &FLAGS_query_profile_ai_analysis_max_concurrent_runs, kMaxConcurrentRuns); : ASSERT_TRUE(TryAcquireAiAnalysisSlot()); : ReleaseAiAnalysisSlot(); : IMPALA_ASSERT_DEBUG_DEATH( > This test can be simplified by calling ASSERT_TRUE(TryAcquireAiAnalysisSlot Done http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc@1402 PS21, Line 1402: tool_output_doc->SetObject(); > The compilation failed with some type conversion on Swap. Maybe we can try Done http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.h File be/src/service/query-profile-redaction.h: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-redaction.h@78 PS21, Line 78: std::unordered_map<std::string, std::string> alias_to_original_; > We probably don't need to store the redacted_profile_text_ anymore? Also no Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 22 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 00:55:32 +0000 Gerrit-HasComments: Yes
