Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc File be/src/service/query-profile-ai-analysis-test.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-ai-analysis-test.cc@145 PS21, Line 145: 3 query_profile_ai_analysis_max_concurrent_runs by default is 3, maybe we change the test limit to 4 (or 2)? http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc File be/src/service/query-profile-parsing-tools.cc: http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc@1402 PS21, Line 1402: tool_output_doc->CopyFrom(out, tool_output_doc->GetAllocator()); It seems we can swap? tool_output_doc->Swap(out); -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 21 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 22:55:42 +0000 Gerrit-HasComments: Yes
