Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24284 )

Change subject: IMPALA-14963: Query Profile AI Analysis Tool
......................................................................


Patch Set 21:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc
File be/src/service/query-profile-parsing-tools.cc:

http://gerrit.cloudera.org:8080/#/c/24284/21/be/src/service/query-profile-parsing-tools.cc@1402
PS21, Line 1402: tool_output_doc->CopyFrom(out, 
tool_output_doc->GetAllocator());
> It seems we can swap?
The compilation failed with some type conversion on Swap. Maybe we can try this 
for zero copy:
tool_output_doc->SetObject();
static_cast<Value&>(*tool_output_doc) = move(out);



--
To view, visit http://gerrit.cloudera.org:8080/24284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e
Gerrit-Change-Number: 24284
Gerrit-PatchSet: 21
Gerrit-Owner: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Gokul Kolady <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 21 May 2026 00:16:54 +0000
Gerrit-HasComments: Yes

Reply via email to