Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@943 PS32, Line 943: AggregationNode q1Final = (AggregationNode) q1Nodes.get(FINAL_AGG_ID); > I can't reproduce the error. Did you rebase the HBO patches onto a special No special commit: the base was 7a3cb82b49, the same parent PS32 has, with IMPALA-15327 PS3 applied on top, and the HBO patches went on top of that. The ids move because the planner picks a different plan for my catalog, not because of a commit. My cluster has a partial testdata load: functional.alltypessmall has no data files and no stats (#Rows=-1). With that catalog the plan has an exchange at node 10 in testAggOnMultiLevelJoinOperands and at node 5 in testMultiLevelOpIndexUnderInnerJoin, which are the two nodes the casts land on. EXPLAIN on the same cluster with a frontend built without IMPALA-15327 and without the HBO patches shows the same exchanges, so it's purely my environment. Sorry for the noise, the fixed ids are fine. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 32 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2026 15:22:28 +0000 Gerrit-HasComments: Yes
