Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 33: Code-Review+2 (1 comment) LGTM. Thanks Quanlong for addressing the comments from the reviewers. Carrying forward Aleksandr and Steve's +1 and bumping mine to +2. http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@106 PS32, Line 106: public static List<String> canonicalizeJoinConjuncts(List<Expr> exprs, > It's handled in the analyze phase where they are converted to BinaryPredica Done -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 33 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 20:14:18 +0000 Gerrit-HasComments: Yes
