Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 32: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24426/32//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24426/32//COMMIT_MSG@51 PS32, Line 51: connicalized nit: canonicalized http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@106 PS32, Line 106: public static List<String> canonicalizeJoinConjuncts(List<Expr> exprs, Do we want to handle USING clause as well ? I haven't checked if it gets expanded in the form of a conjunct by the time this code is executed. This is one of the supported join syntaxes for Impala: https://impala.apache.org/docs/build/asf-site-html/topics/impala_joins.html If this already works for HBO, it would be good to add a test case. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 32 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 07:31:05 +0000 Gerrit-HasComments: Yes
