Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 33: (3 comments) http://gerrit.cloudera.org:8080/#/c/24426/32//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24426/32//COMMIT_MSG@51 PS32, Line 51: canonicalize > nit: canonicalized Done http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@106 PS32, Line 106: public static List<String> canonicalizeJoinConjuncts(List<Expr> exprs, > Do we want to handle USING clause as well ? I haven't checked if it gets e It's handled in the analyze phase where they are converted to BinaryPredicates: https://github.com/apache/impala/blob/80c57fa9b63e0ac285b324bac54cc60af0055f3a/fe/src/main/java/org/apache/impala/analysis/TableRef.java#L690-L694 Added testJoinClauses in HboKeyStringTest for this. http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@943 PS32, Line 943: // alltypes=op0.0 and alltypestiny=op0.1. alltypessmall is the outer join's right > No special commit: the base was 7a3cb82b49, the same parent PS32 has, with Ack -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 33 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 11:02:34 +0000 Gerrit-HasComments: Yes
