Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 32: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24426/32/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@943 PS32, Line 943: AggregationNode q1Final = (AggregationNode) q1Nodes.get(FINAL_AGG_ID); Two HboKeyStringTest cases fail in my test environment with the current HBO stack: testAggOnMultiLevelJoinOperands() casts an ExchangeNode to AggregationNode here, and testMultiLevelOpIndexUnderInnerJoin() does the same with JoinNode at line 1009. Both lookups use fixed plan-node IDs. The failures also occur when I replace PlanNode with the PS31 version. Could we find the aggregations by traversing the plan and select the single INNER join by its join type? With that test-only change, all 49 tests in the stacked HboKeyStringTest pass with the existing expected keys unchanged. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 32 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2026 13:50:28 +0000 Gerrit-HasComments: Yes
