Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 31: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/31/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24426/31/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1135 PS31, Line 1135: Preconditions.checkState(getTupleIds().size() == 1, : "%s has %s tuples so should override buildHboOperandQualifierMap()", : getDisplayLabel(), getTupleIds().size()); > This is too strict. buildHboOperandQualifierMap() could run on nodes that H Confirmed with three focused checks: PS32 handles a multi-tuple EmptySetNode, including below a join and through a SelectNode. Using the PS31 PlanNode reproduces the assertion in both join cases. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 31 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2026 13:49:39 +0000 Gerrit-HasComments: Yes
