Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11805 )

Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16
PS1, Line 16: Testing:
            : - Ran the test file locally.
The queries are fine, but what does it mean to run these locally? I'm not too 
familiar with these workloads (targeted-perf, targeted-stress). Do the queries 
get run in GVO? Is it expected downstream larger-scale testing will run these? 
The stress test (concurrent_select.py) won't find these queries, for example.



--
To view, visit http://gerrit.cloudera.org:8080/11805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9
Gerrit-Change-Number: 11805
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:29:11 +0000
Gerrit-HasComments: Yes

Reply via email to