Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 )
Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16 PS1, Line 16: Testing: : - Ran the test file locally. > By "run locally" I mean that I put together a python test that run the file You could: 1. Put the queries into the tpch workload directory 2. Get them running regularly in query_test/test_tpch.py so that your queries run in regular CI immediately 3. Alter the stress test regex and unit test that makes sure all expected queries are there Commentary: The easiest way to get them into the stress test is to add queries, 1 query per .test file, to the tpch workload, and extend the regex to match the files you added. To prevent the regex/matching from regressing, there are CI tests to make sure we match an expected number of files (at least two bugs in the past have busted the matching when people altered the countents of the tpc workload directories). That test is here: https://github.com/apache/impala/blob/master/tests/infra/test_stress_infra.py#L53 . You could also run the queries in query_test/test_tpch.py, at which point you'll have regular CI on these queries as opposed to them being put into odd workloads. -- To view, visit http://gerrit.cloudera.org:8080/11805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9 Gerrit-Change-Number: 11805 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 31 Oct 2018 17:54:08 +0000 Gerrit-HasComments: Yes
