Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 )
Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16 PS1, Line 16: Testing: : - Ran the test file locally. > > One problem with putting these queries in the tpch workload and > changing the regex is that there are already a number of query > files in the tpch workload other than the regular tpch queries > which presumably weren't written with the idea of being part of the > stress test and aren't necessarily interesting for it. > > How is this a problem? The regex could opt in to the queries you > add without including the ones we're not interested in. I don't > personally see anything wrong with the stress- idea. This is what I ended up going with -- To view, visit http://gerrit.cloudera.org:8080/11805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9 Gerrit-Change-Number: 11805 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 20:26:49 +0000 Gerrit-HasComments: Yes
