Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 )
Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16 PS1, Line 16: Testing: : - Ran the test file locally. > we currently don't run anything in the stress test other than the regular > tpch/ds queries. Is that correct? Correct. > One problem with putting these queries in the tpch workload and changing the > regex is that there are already a number of query files in the tpch workload > other than the regular tpch queries which presumably weren't written with the > idea of being part of the stress test and aren't necessarily interesting for > it. How is this a problem? The regex could opt in to the queries you add without including the ones we're not interested in. I don't personally see anything wrong with the stress- idea. In general there is a problem with our test data and workload organization, because a workload is about query characteristics, but a given workload may depend on one or more different data sets, and it's kind of a mess. There's nothing to bind that workload with the data it needs. Putting everything into tpch at least helps keep that binding, albeit softly: "We load TPCH data, and here are the queries that use TPCH data". > how would you feel if I resurrected the targeted-stress workload for this > purpose? It depends on how you plan to implement it. agg_stress.test and stress-with-invalidate-refresh.test won't work for the parser because there are multiple statements in the files, so you can't just whitelist this entire directory. That will make your patch larger. Note too --query-file-path exists. -- To view, visit http://gerrit.cloudera.org:8080/11805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9 Gerrit-Change-Number: 11805 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 19:10:49 +0000 Gerrit-HasComments: Yes
