Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 )
Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16 PS1, Line 16: Testing: : - Ran the test file locally. > The queries are fine, but what does it mean to run these locally? I'm not t By "run locally" I mean that I put together a python test that run the files with run_test_case(), like we would do for an equivalent file in the functional-query workload. The idea was to verify that I had the RESULTS/TYPES/LABELS sections correct. The targeted-perf workload is used by single_node_perf_run.py. I believe its something that Mostafa also used to run to check for regressions between releases. Even if no one is running it currently, it seems reasonable to me to add these queries for the future when there is someone paying closer attention to perf issues. The targeted-stress workload seems to be pointless. Its only references in tests/stress/test_mini_stress.py and all of the tests there have been xfailed for years. Probably we should remove targeted-stress, or even better move the queries in workloads/tpch/ that aren't actually regular tpch queries to targeted-stress and modify the stress test to use them. It would also be great to re-enable the tests in test_mini_stress.py, even if just to ensure that the RESULTS/TYPES/LABELS sections stay up to date. That's all (hopefully) outside the scope of this patch. Yes, the intention is for these to be run as part of downstream larger-scale testing. Is there any way to accomplish that currently? It seems that concurrent_select won't find them even if I add them to eg. testdata/workloads/tpch/queries/tpch-aggregations.test, as it only checks for test files of the form 'tpch-q*.test' -- To view, visit http://gerrit.cloudera.org:8080/11805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9 Gerrit-Change-Number: 11805 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Oct 2018 20:55:23 +0000 Gerrit-HasComments: Yes
