Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 )
Change subject: IMPALA-7761: Add multiple DISTINCT to targeted stress and perf ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11805/1//COMMIT_MSG@16 PS1, Line 16: Testing: : - Ran the test file locally. > You could: So I guess I didn't realize before making this patch from conversation I had people, that we currently don't run anything in the stress test other than the regular tpch/ds queries. Is that correct? One problem with putting these queries in the tpch workload and changing the regex is that there are already a number of query files in the tpch workload other than the regular tpch queries which presumably weren't written with the idea of being part of the stress test and aren't necessarily interesting for it. Of course, we could do something like specify that any query files in the tpch workload that should be included in the stress test are prepended with 'stress-' or something, but how would you feel if I resurrected the targeted-stress workload for this purpose? I would also add a param to concurrent_select to control this, something like --use-targeted-stress with a default of false. I would then propose also adding these queries to regular CI by enabling tests in stress/test_mini_stress.py (not to actually run concurrently or in a loop, just to do a regular run_test_case call) -- To view, visit http://gerrit.cloudera.org:8080/11805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I400aaf6b6620b4001895eafff785956bffb312c9 Gerrit-Change-Number: 11805 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 02 Nov 2018 19:56:10 +0000 Gerrit-HasComments: Yes
