Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 4: Code-Review+1 (1 comment) About testing: I couldn't come up with anything else than Tim's sanity test. I am ok with testing this one manually, but a test like that would be a nice addittion. http://gerrit.cloudera.org:8080/#/c/16419/4/be/src/exec/kudu-util-ir.cc File be/src/exec/kudu-util-ir.cc: http://gerrit.cloudera.org:8080/#/c/16419/4/be/src/exec/kudu-util-ir.cc@54 PS4, Line 54: // TODO: codegen this to eliminate branching on type. I am not sure if this is still relevant - after this change this function in called with constant col_type argument in the codegend code, so the llvm optimizer has the chance to remove this branch if it inlines the function. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Sep 2020 10:30:50 +0000 Gerrit-HasComments: Yes
